Feat/v2 e2e tests#3
Open
ev-shindin wants to merge 5 commits intomainfrom
Open
Conversation
Add e2e test jobs for the V2 saturation engine that mirror the existing V1 tests. V2 smoke tests run automatically on every PR alongside V1, while V2 full tests are triggered by ChatOps comments with -v2 suffix (/trigger-e2e-full-v2, /test-e2e-full-v2, /test-full-v2). Changes: - CI: add check-full-tests-v2, e2e-tests-smoke-v2, e2e-tests-full-v2 jobs - CI: update report-status to emit separate V1/V2 status contexts - Makefile: pass ANALYZER_NAME to deploy-e2e-infra - Helm: conditionally render analyzerName in ConfigMap template - Helm: add analyzerName field to values.yaml and values-dev.yaml - install.sh: accept ANALYZER_NAME env var for helm --set
parseSaturationConfig() called Validate() without first calling ApplyDefaults(), causing V2 configs with analyzerName: saturation to fail validation because scaleUpThreshold/scaleDownBoundary default to zero (omitempty) and Validate() rejects zero values. This caused the engine to skip all models with "Saturation scaling config not loaded yet for namespace", resulting in no scaling decisions.
When the model server does not emit the vllm:cache_config_info metric (e.g., llm-d-inference-sim), TotalKvCapacityTokens is 0 and the V2 analyzer skipped the replica entirely, resulting in totalDemand=0 and no scale-up decisions. Add computeReplicaCapacityFallback that uses the deployment-derived capacity from the capacity store and estimates demand from KvCacheUsage percentage. This allows V2 to produce scaling decisions with any vLLM-compatible server, not just those emitting cache_config_info.
Add /ok-to-test-v2 and /retest-v2 ChatOps commands that deploy with analyzerName: saturation for V2 capacity-constraint analyzer testing on real GPU hardware. Also adds analyzer_name workflow_dispatch input.
|
This PR is marked as stale after 21d of inactivity. After an additional 14d of inactivity (7d to become rotten, then 7d more), it will be closed. To prevent this PR from being closed, add a comment or remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test